feat(payment): PI-2771 Rename region for product item. #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-phargelm
requested review from
bc-alexsaiannyi,
bc-akravets and
bc-yevhenii-buliuk
bc-akravets
approved these changes
Jan 3, 2025
bc-yevhenii-buliuk
approved these changes
Jan 3, 2025
bc-alexsaiannyi
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up PR for #2530.
In the previous PR, I added new regions to several shared product components. During testing, it was noticed that these components are injected not only on category pages but also on the product view page (as a list of related products at the bottom). The problem is that the product view page already has a region with the same name. Thus, injecting components with the same region name leads to the multiplication of an existing banner intended for the product details page. This fix is intended to rename the regions introduced in #2530 to avoid unexpected behavior. The old names are not used by any store yet, as they were merged recently.
Requirements
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Attach images or add image links here.
See related bcapp PR for use cases: https://github.com/bigcommerce/bigcommerce/pull/61296