[BUG] Convert LALDict to python dictionary before saving #825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #751. Uses lalsimulation.gwsignal.core.utils.from_lal_dict to convert a LALDict to a python dictionary before saving.
I have a few concerns which I was not sure how to tackle:
The new logic has the downside that it is the only part of code in
core/result.py
that depends on a function in gw. The other option is to define anequivalent _get_save_data_dictionary
inside theCompactBinaryCoalescenceResult
class.Right now this imports the relevant function from LALSimulation, but we could have just copied over the relevant code into bilby (since LALSuite is under GNU GPL).
Migrated from git.ligo: https://git.ligo.org/lscsoft/bilby/-/merge_requests/1309