DEV: make sure all priors return float when needed #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # bilby/core/utils/calculus.py
ColmTalbot
changed the title
mj-will
reviewed
Jan 13, 2025
mj-will
reviewed
Jan 13, 2025
|
I've double checked the Fermi-Dirac prior CDF and it gives the correct expected result. |
mj-will
reviewed
Feb 4, 2025
Comment on lines
+863
to
+868
| for names in joint.values(): | ||
| values = list() | ||
| for key in names: | ||
| values = np.concatenate([values, result[key]]) | ||
| for key, value in zip(names, values): | ||
| result[key] = value |
There was a problem hiding this comment.
Could you help me understand what this loop is doing? I'm finding the logic of this part a bit hard to follow, it might benefit from a comment.
asb5468
reviewed
Feb 6, 2025
| def test_cdf_float_with_float_input(self): | ||
| for prior in self.priors: | ||
| if ( | ||
| bilby.core.prior.JointPrior in prior.__class__.__mro__ |
There was a problem hiding this comment.
Why is this test skipped for JointPriors with no finite upper bound?
asb5468
requested changes
Feb 6, 2025
|
@ColmTalbot it looks like there are conflicts following #849 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time, some prior classes have cast inputs to numpy arrays this MR removes that behaviour and adds a test to make sure that sampling and evaluating the CDF do not cast to array.
This caused an error when evaluating the CDF many times and then combining the results.
I also streamlined some other behaviour in applying prior constraints that were originally flagged by @cjhaster.
I noticed that the Fermi-Dirac CDF hadn't been implemented for some reason so I added that and added to the CI test suite.
Finally, there was an issue with sampling from joint distributions where the results could be returned out of order.
Copied from https://git.ligo.org/lscsoft/bilby/-/merge_requests/1285