ENH: Added the CBCResult class to all gw examples

[MattiaEmma2022]

Added a line in each result of CBC sampling occurrences to specify the result_class to be CBCResult

[GregoryAshton]

@MattiaEmma2022 it looks like the pre-commit is failing. To fix this you can

1. Install pre-commit locally with pip install pre-commit
2. Runpre-commit run --all-files on this branch, this will make the necessary changes
3. Add the files and commit them

If you want to avoid this process in future, run pre-commit install.

[mj-will]

Thanks for this Mattia! Looks good to me, however, I think the example in supernova_example needs updating as well (it uses the GW likelihood).

[GregoryAshton]

Thanks for this Mattia! Looks good to me, however, I think the example in supernova_example needs updating as well (it uses the GW likelihood).

Does it make sense to use a CBCResult for a supernova analysis? I suspect that will cause issues as the CBCResult assumes the existence of certain parameters.

[mj-will]

Does it make sense to use a CBCResult for a supernova analysis? I suspect that will cause issues as the CBCResult assumes the existence of certain parameters.

It might be worth looking at this in more detail. I was thinking of all the interferometer, cosmology and waveform arguments which I think will still work but there may be some others that work. That said, it does use the GraviationalWaveTransient likelihood that has all the marginalizations.

From the name though, I suppose it doesn't make sense to use it here. Perhaps this is an indication we should have a base GWResult from which CBCResult inherits?

[GregoryAshton]

Does it make sense to use a CBCResult for a supernova analysis? I suspect that will cause issues as the CBCResult assumes the existence of certain parameters.

It might be worth looking at this in more detail. I was thinking of all the interferometer, cosmology and waveform arguments which I think will still work but there may be some others that work. That said, it does use the GraviationalWaveTransient likelihood that has all the marginalizations.

From the name though, I suppose it doesn't make sense to use it here. Perhaps this is an indication we should have a base GWResult from which CBCResult inherits?

Maybe, but I would suggest this is getting into the territory of "A foolish consistency is the hobgoblin of little minds" - i.e. I think in practise a GWResult with CBCResult subclass would be the correct way to implement it, but I don't think it is worthwhile (just my 2c).