Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow tilde in conda version constraints #1033

Merged

Conversation

dlaehnemann
Copy link
Member

See conda package match specifications:

https://docs.conda.io/projects/conda-build/en/25.1.x/resources/package-spec.html#package-match-specifications

This syntax has also been around for a bit, I can already see it in the 24.1.x docs.

@dlaehnemann
Copy link
Member Author

I think this is a simple change and ready for review. I can't assign anybody for review, so I'll try pinging the people I saw in the latest merged PRs. 😅

@daler @aliciaaevans @bgruening

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bgruening
Copy link
Member

Thanks @dlaehnemann

@dlaehnemann
Copy link
Member Author

Thanks @bgruening ! It seems I also can't merge this pull request, as I don't have write access to this repo. So someone else will have to do it.

@daler daler merged commit 017e54d into bioconda:master Jan 28, 2025
9 checks passed
@daler
Copy link
Member

daler commented Jan 28, 2025

Thanks for the fix; merged. Next step will be releasing and then modifying https://github.com/bioconda/bioconda-common to use the latest version.

@dlaehnemann dlaehnemann deleted the fix/allow-tilde-in--version-contraints branch January 29, 2025 14:41
@dlaehnemann
Copy link
Member Author

Thanks for the merge!

I guess without write access, I can't usefully review or merge the release PR, but it's already there:
#1034

aliciaaevans pushed a commit that referenced this pull request Jan 29, 2025
🤖 I have created a release \*beep\* \*boop\*
---
###
[3.7.1](https://www.github.com/bioconda/bioconda-utils/compare/v3.7.0...v3.7.1)
(2025-01-28)


### Bug Fixes

* allow tilde in conda version constraints
([#1033](https://www.github.com/bioconda/bioconda-utils/issues/1033))
([017e54d](https://www.github.com/bioconda/bioconda-utils/commit/017e54de1779e4e0284fa02ca379c585d416c30c))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants