Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECCODE pattern to allow optional dashes #1396

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Update ECCODE pattern to allow optional dashes #1396

merged 4 commits into from
Feb 3, 2025

Conversation

bgyori
Copy link
Contributor

@bgyori bgyori commented Jan 31, 2025

This PR aims to resolve the longstanding discussion at #681 by optionally allowing dashes in EC codes. Since my summary in #681 (comment) which has gotten a few endorsements there has not been an opposing argument from the community so I think this is the best path forward.

Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we wait until the Bioregistry workshop at Biocuration 2025 to have a more productive in-person discussion, and try and address the remaining open questions from that thread before making any changes?

We can also try and develop materials to help guide future similar high impact and difficult discussions - I added an initial proposal in #1397

@bgyori
Copy link
Contributor Author

bgyori commented Feb 1, 2025

#681 has been open for more than 2 years, with 7 people other than @cthoyt and myself weighing in. I can't see a single comment from the community that is against allowing dashes, all comments are either supportive (many like @cmungall actively asking for this on many forums) or neutral. So why prolong the discussion? This is a community-driven project and the stance of the community is very clear here.

These decoys are for if there are too few dashes or too many dashes, when being used
Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this with some additional context in the description

@cthoyt cthoyt merged commit ace8b61 into main Feb 3, 2025
12 checks passed
@cthoyt cthoyt deleted the eccode_pattern branch February 3, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants