Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing GO entries #1411

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Fixing GO entries #1411

merged 3 commits into from
Feb 11, 2025

Conversation

cmungall
Copy link
Contributor

  • Fixing URL for GO CAMs (go.model)
  • Fixed error in name (Activity not Assembly)
  • Fixed URL for GO_REFs

cmungall and others added 2 commits February 10, 2025 17:41
- Fixing URL for GO CAMs (go.model)
- Fixed error in name (Activity not Assembly)
- Fixed URL for GO_REFs
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.80%. Comparing base (8950e70) to head (718b8ea).
Report is 308 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1411      +/-   ##
==========================================
+ Coverage   42.51%   46.80%   +4.28%     
==========================================
  Files         117      118       +1     
  Lines        8327     8331       +4     
  Branches     1963     1354     -609     
==========================================
+ Hits         3540     3899     +359     
+ Misses       4582     4239     -343     
+ Partials      205      193      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cthoyt
Copy link
Member

cthoyt commented Feb 11, 2025

thanks @cmungall. I updated your PR to retain the legacy URLs, since they probably appear in sources we want the Bioregistry to support parsing the URLs from.

I also added a few more flags for other GO prefixes, perhaps you can do an audit and make a follow-up PR to clarify who's the contact for each GO prefix, what the canonical prefix should be (similar to your request in #1410), and anything else that can improve those records

@cthoyt cthoyt merged commit 60c44c3 into biopragmatics:main Feb 11, 2025
14 checks passed
@cmungall
Copy link
Contributor Author

The json looks good but I'm a bit confused as to why this hasn't propagated to the site yet...

@cthoyt
Copy link
Member

cthoyt commented Feb 14, 2025

The json looks good but I'm a bit confused as to why this hasn't propagated to the site yet...

Sorry about this, it's related to how the bioregistry's CI/CD works. I opened a new issue for fixing this in #1416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants