Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename clingene to clingen.allele #1412

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Rename clingene to clingen.allele #1412

merged 4 commits into from
Feb 12, 2025

Conversation

nagutm
Copy link
Collaborator

@nagutm nagutm commented Feb 11, 2025

This pull request addresses the following issue: #1403

The following changes were implemented:

  1. Updated the clingene prefix to clingen.allele in order to explicitly represent allele-related identifiers. I have maintained clingene as a synonym for the prefix.
    2. Updated all instances of clingene to clingen.allele. These include:
    - Data files for testing curie and uri benchmarks
    - ttl and jsonId files under contexts
  2. Maintained clingen.affiliation since it better aligns with the terminology and URL pattern for the resource.

@nagutm nagutm requested a review from bgyori February 11, 2025 15:20
@cthoyt
Copy link
Member

cthoyt commented Feb 11, 2025

please try to keep the changes to auto-generated files out of PRs mixed with curated data changes

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.80%. Comparing base (8950e70) to head (1435f3b).
Report is 310 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1412      +/-   ##
==========================================
+ Coverage   42.51%   46.80%   +4.29%     
==========================================
  Files         117      118       +1     
  Lines        8327     8332       +5     
  Branches     1963     1354     -609     
==========================================
+ Hits         3540     3900     +360     
+ Misses       4582     4239     -343     
+ Partials      205      193      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagutm
Copy link
Collaborator Author

nagutm commented Feb 11, 2025

Thanks for the clarification @cthoyt , there was a misunderstanding on my part. I will work on reverting those changes.

@nagutm nagutm changed the title Rename clingene to clingen.allele and update all instances Rename clingene to clingen.allele Feb 11, 2025
@cthoyt cthoyt merged commit 7fae7ba into biopragmatics:main Feb 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants