Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename eccode to ec #1413

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Rename eccode to ec #1413

wants to merge 11 commits into from

Conversation

nagutm
Copy link
Collaborator

@nagutm nagutm commented Feb 12, 2025

This pull request addresses the following issue: #1404

The following changes are implemented:

  • Rename eccode prefix to ec
  • preferred_prefix is set to EC
  • Maintain eccode as a synonym
  • Update any instances of provides: eccode to provides: ec

A few additional files that referenced eccode are updated to reflect this change as well.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.80%. Comparing base (8950e70) to head (6bd4d1e).
Report is 309 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
+ Coverage   42.51%   46.80%   +4.29%     
==========================================
  Files         117      118       +1     
  Lines        8327     8332       +5     
  Branches     1963     1354     -609     
==========================================
+ Hits         3540     3900     +360     
+ Misses       4582     4239     -343     
+ Partials      205      193      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagutm nagutm requested a review from bgyori February 12, 2025 02:35
Copy link
Contributor

@bgyori bgyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@bgyori
Copy link
Contributor

bgyori commented Feb 12, 2025

Oh actually, just noticed one more small thing, we might want to update this sentence:

Identifiers.org's `ec-code` was renamed to `eccode` while maintaining `ec-code`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants