Handle inflate returning Z_OK at end of stream #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inflate function may return Z_OK rather than Z_STREAM_END when the last bytes of the stream are inflated. In this case inflate returns Z_STREAM_END on the next call. However in this situation we will already have reset avail_out for the next line and the "d_stream.avail_out == 0" condition will be false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inflate function may return
Z_OKrather thanZ_STREAM_ENDwhen the last bytes of the stream are inflated. In this case inflate returnsZ_STREAM_ENDon the next call. However in this situation we will already have resetavail_outfor the next line and thed_stream.avail_out == 0condition will be false.The zlib documentation is not very clear about this, but I have verified that it still behaves this way in version 1.3.1.