-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initEccLib skip verification (v6) #2184
feat: initEccLib skip verification (v6) #2184
Conversation
I would like to see it be a bit more self-documenting. Someone could add a single line "true" diff and most people won't blink an eye. Instead of a boolean, maybe the type should be |
|
Thanks @junderw , what do you think now? |
How about |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Bump the patch version (both package and package-lock) and add something to CHANGELOG. |
Published. |
Nice! thanks @junderw. I'll update v7 |
verifyEcc could be expensive, taking up to 500 ms to finish on some devices. This PR allows the client code to avoid running the verification on boot with a flag. Devs can run the verification on unit tests to verify if the provided ECC is correct.
This is for V6, we are currently running this version