Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop address books authority #1217

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Drop address books authority #1217

merged 3 commits into from
Jan 7, 2025

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Jan 2, 2025 •
edited
Loading

Purpose

Since #1177 the address_books_authority is not required anymore and this PR removes it and any remaining usages.

Short description

  • drop unused method toSyncAuthority
  • AutomaticSyncManager falsely translated the CONTACTS constant to context.getString(R.string.address_books_authority) and passed it to the content providers to set sync settings. Replaced it with ContactsContract.AUTHORITY.
  • replace context.getString(R.string.address_books_authority) calls in migrations with constant value
  • remove remaining context.getString(R.string.address_books_authority) calls
  • also removed address_books_authority_title since there are no usages.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the refactoring Internal improvement of existing functions label Jan 2, 2025
@sunkup sunkup self-assigned this Jan 2, 2025
@sunkup sunkup linked an issue Jan 2, 2025 that may be closed by this pull request
Drop address_books_authority #1216
Closed
@sunkup sunkup marked this pull request as ready for review January 2, 2025 12:23
@sunkup sunkup requested a review from ArnyminerZ January 2, 2025 12:23
ArnyminerZ
ArnyminerZ requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@ArnyminerZ ArnyminerZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing. Looks good otherwise.

app/src/main/kotlin/at/bitfire/davdroid/settings/migration/AccountSettingsMigration14.kt Show resolved Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/settings/migration/AccountSettingsMigration19.kt Show resolved Hide resolved
@sunkup sunkup requested a review from rfc2822 January 2, 2025 15:23
ArnyminerZ
ArnyminerZ approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@ArnyminerZ ArnyminerZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

rfc2822
rfc2822 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes looks fine 😃

@rfc2822 rfc2822 merged commit 62dc374 into main-ose Jan 7, 2025
8 checks passed
@rfc2822 rfc2822 deleted the 1216-drop-address_books_authority branch January 7, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnyminerZ ArnyminerZ ArnyminerZ approved these changes

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@sunkup sunkup

Labels
refactoring Internal improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop address_books_authority
3 participants
@sunkup @rfc2822 @ArnyminerZ