Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Websockets support #42

Open
razb opened this issue Nov 16, 2014 · 18 comments
Open

Websockets support #42

razb opened this issue Nov 16, 2014 · 18 comments

Comments

@razb
Copy link

razb commented Nov 16, 2014

It appears that the proxy does not support web-sockets. Any plans to add that support?

Thanks for a great product!

@jehiah
Copy link
Member

jehiah commented Nov 17, 2014

@razb There has been some work on this by @airhorns in #14

@jehiah jehiah closed this as completed Nov 17, 2014
@razb
Copy link
Author

razb commented Nov 17, 2014

Perfect. This works for me!

Thanks again

@hexedpackets
Copy link

There are now two separate PRs opened to add websocket support - #14 and #64 - but no movement on either. The first hasn't been touched in over a year. Can we have this issue re-opened as a tracker until support is actually added?

@jehiah jehiah reopened this May 21, 2015
@pgr0ss
Copy link

pgr0ss commented Jun 1, 2015

👍 I would love support for websockets.

@igorgatis
Copy link

+1

1 similar comment
@okev
Copy link

okev commented Jun 20, 2015

+1

@jehiah
Copy link
Member

jehiah commented Jun 20, 2015

I love seeing the support for this feature. Anyone want to champion this with a patch to add websocket support?

@sammerry
Copy link

+1 running into this same problem trying to proxy ipython.

@neurogenesis
Copy link

+1, @jehiah ... looks like the following PR (comments as recent as 13 days ago) was also submitted to address this. adding to this thread for visibility...

#145

@emirot
Copy link

emirot commented Sep 15, 2016

Is there any chance to have websockets supported anytime soon ?

@917huB
Copy link

917huB commented Oct 2, 2016

likewise... big +1 here

@chris-martin
Copy link

As a workaround, you can use nginx with auth_request, right?

@917huB
Copy link

917huB commented Oct 6, 2016

looks like someone figured out how to integrate the web sockets fixes into a fork of this.
https://github.com/funkymrrogers/oauth2_proxy

@thunderace
Copy link

This work for me (nodered behing nginx/oauth2_proxy :

server {
	listen   443;
	server_name     nodered.mycompany.fr;
	ssl on;
	ssl_certificate /etc/letsencrypt/live/nodered.mycompany.fr/fullchain.pem;
	ssl_certificate_key /etc/letsencrypt/live/nodered.mycompany.fr/privkey.pem;	
	ssl_session_timeout 5m;
  ssl_protocols TLSv1 TLSv1.1 TLSv1.2;
  ssl_ciphers ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA:ECDHE-RSA-AES128-SHA:DHE-RSA-AES256-SHA:DHE-RSA-AES128-SHA;
  ssl_session_cache shared:SSL:50m;
  ssl_prefer_server_ciphers on;
	add_header Strict-Transport-Security max-age=2592000;
  
  location /oauth2/ {
    proxy_pass       http://127.0.0.1:4180;
    proxy_set_header Host                    $host;
    proxy_set_header X-Real-IP               $remote_addr;
    proxy_set_header X-Scheme                $scheme;
    proxy_set_header X-Auth-Request-Redirect $request_uri;
  }	
  
  location / {
    auth_request /oauth2/auth;
    error_page 401 = /oauth2/sign_in;
    # pass information via X-User and X-Email headers to backend,
    # requires running with --set-xauthrequest flag
    auth_request_set $user   $upstream_http_x_auth_request_user;
    auth_request_set $email  $upstream_http_x_auth_request_email;
    proxy_set_header X-User  $user;
    proxy_set_header X-Email $email;

    # if you enabled --cookie-refresh, this is needed for it to work with auth_request
    auth_request_set $auth_cookie $upstream_http_set_cookie;
    add_header Set-Cookie $auth_cookie;
    proxy_pass http://192.168.1.230:3008;

    chunked_transfer_encoding off;
    proxy_buffering off;
    proxy_cache off;  

  	proxy_redirect     off;
  	proxy_http_version 1.1;
  	proxy_set_header Upgrade $http_upgrade;
  	proxy_set_header Connection "Upgrade";
  	proxy_set_header Host $http_host;
    }
}

@mizzao
Copy link

mizzao commented Jan 5, 2018

See also #201 and #145 and #486.

I'm guessing the creators don't use WS in their deployments and that's why it hasn't been merged.

@chirino
Copy link

chirino commented Jan 15, 2018

Luckily the folks at https://github.com/openshift/oauth-proxy have merged in the websocket support so I guess folks could just switch to that if it's an issue. Thank goodness for open source forks.

@Freundschaft
Copy link

alright, so no chance that this will ever be merged i guess?

@ryuheechul
Copy link

Hope this repo supports websockets and it would be very helpful many websites use websockets

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests