-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Cloudfoundry provider #207
base: master
Are you sure you want to change the base?
Conversation
aadad76
to
35228c8
Compare
35228c8
to
825f9bc
Compare
132452f
to
825f9bc
Compare
825f9bc
to
e3d5390
Compare
Running the
However, the build fails. Am I running it wrong? @jehiah Is there perhaps something I'm missing? |
Travis has the log of what failed which you can inspect. It's this:
|
Yep @ploxiln, however, the error seems to be something that isn't related to my dev changes. I've rerun the tests locally, both on OSX and ubuntu, and they are successful every time. That's why I'm asking, am I doing something wrong, or is it a problem with the travis container in which the tests run? |
If this would make life easier for the committers I could open a new PR for this issue that removes the unrelated commit for issue #205 and squashes the remaining commits into one. |
* Added a cloudfoundry provider (cloudfoundry.go) to interface with cloudfoundry's UAA [1] * Provide defaults for local Cloudfoundry installation on BOSH lite [2] [1] https://github.com/cloudfoundry/uaa [2] https://github.com/cloudfoundry/bosh-lite
e3d5390
to
aae11e6
Compare
I separated the cloudfoundry provider code from unrelated issue #205 (there will be a separate PR for that) Checks are passing, let me know if there is anything more we should add or fix here |
Is anyone ever going to look at this PR ? |
Now that there's an OIDC provider, this might not be necessary, since the Cloud Foundry UAA speaks OIDC. |
yes I can confirm that oauth2_proxy works with Cloudfoundry UAA and the OIDC provider. |
this adds a provider for Cloudfoundry's UAA [1]
if you think this makes sense we can also add some unit tests.
The second commit allows to set X-Forwarded-User independent of HTTP Basic Auth as we need this for our Cloudfoundry/grafana scenario [2]
[1] https://github.com/cloudfoundry/uaa
[2] http://docs.grafana.org/installation/configuration/#authproxy