This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
add support for basic auth user instead of oauthed user with basic auth #275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to find out that when authenticating to an upstream there were only the following supported configurations:
a) pass X-Forwarded-User and X-Forwarded-Email
b) pass X-Forwarded-User and X-Forwarded-Email with a configured basic auth password (-basic-auth-password)
c) pass nothing
A common usecase I've run into is passing full basic auth to an upstream (with credentials that are machine-generated and no one sees), and presenting oauth to an end-user. In that scenario, the above options aren't particularly useful. This PR adds a parameter to allow passing a basic auth password AND user to an upstream. We can still pass X-Forwarded-User and X-Forwarded-Email as additional headers, but the username passed with the auth header is not just a duplicate of the X-Forwarded-User.