Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

add support for basic auth user instead of oauthed user with basic auth #275

Closed
wants to merge 1 commit into from

Conversation

rremer
Copy link
Contributor

@rremer rremer commented Jul 1, 2016

I was surprised to find out that when authenticating to an upstream there were only the following supported configurations:
a) pass X-Forwarded-User and X-Forwarded-Email
b) pass X-Forwarded-User and X-Forwarded-Email with a configured basic auth password (-basic-auth-password)
c) pass nothing

A common usecase I've run into is passing full basic auth to an upstream (with credentials that are machine-generated and no one sees), and presenting oauth to an end-user. In that scenario, the above options aren't particularly useful. This PR adds a parameter to allow passing a basic auth password AND user to an upstream. We can still pass X-Forwarded-User and X-Forwarded-Email as additional headers, but the username passed with the auth header is not just a duplicate of the X-Forwarded-User.

@rremer
Copy link
Contributor Author

rremer commented Jul 14, 2016

Didn't see #206 for some reason, closing this out since his has a nice test with it.

@rremer rremer closed this Jul 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant