This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Pass UserId as header #276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # oauthproxy.go # options.go # providers/github.go
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello to the bitly team. Thanks for sharing this project! We've been using it to front Rundeck and have some enhancements from that experience we'd like to share.
When creating relational data based on the proxying user's identity it's fragile to rely on usernames or email addresses (in the case of Github, either can change). This enhancement adds an additional configuration to pass a header with the user's id, implemented for the Github provider.
Looking forward to your feedback - Thanks!
John