This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
default to redirecting to current page #483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "-skip-provider-button" flag is used, currently a user is always redirected to "/", whereas a user should be redirected to the page, that was initially requested.
|
consider if the sign_in page was directly visited, and see also #395 |
|
Sorry it took so long. I addressed the sign in page redirect issue, I'd be great if this can land in 2.3. Is there an ETA? |
|
It looks like |
brancz
force-pushed
the
start-redirect
branch
from
6b842a5 to
5c15b01
Compare
brancz
force-pushed
the
start-redirect
branch
from
5c15b01 to
2d90a92
Compare
|
Any update on this PR? Would be great to have this fixed. |
|
Same here 🙂 Happy to fix anything if someone gives this a review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "-skip-provider-button" flag is used, currently a user is always
redirected to "/", whereas a user should be redirected to the page, that
was initially requested.
@jehiah