Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kafka] Fix 'sasl.client.passwords' not working during chart upgrade #27097

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

migruiz4
Copy link
Member

Description of the change

Fixes an issue where the value sasl.client.passwords would be ignored if set during chart upgrade.

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added the kafka label Jun 11, 2024
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Jun 11, 2024
@github-actions github-actions bot requested a review from fmulero June 11, 2024 14:46
Signed-off-by: Miguel Ruiz <[email protected]>
@migruiz4 migruiz4 force-pushed the kafka-upgrade-pass branch from 0f1bdc2 to cda2d3a Compare June 11, 2024 14:54
dgomezleon
dgomezleon previously approved these changes Jun 11, 2024
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Bitnami Containers <[email protected]>
@migruiz4
Copy link
Member Author

Tested using the following values:

  client:
    users:
      - user1
      - user2
    passwords: "pass1,pass2"


==>

  client:
    users:
      - user1
      - user2
    passwords: "newpass1,newpass2"

Result:

$ k get secrets kafka-user-passwords -o jsonpath='{.data.client-passwords}' | base64 -d
pass1,pass2% 
$ helm upgrade kafka bitnami/kafka  -f values.yaml
...                                            
$ k get secrets kafka-user-passwords -o jsonpath='{.data.client-passwords}' | base64 -d
newpass1,newpass2

dgomezleon
dgomezleon previously approved these changes Jun 11, 2024
Signed-off-by: Bitnami Containers <[email protected]>
@migruiz4 migruiz4 merged commit 5f2e38d into main Jun 13, 2024
8 checks passed
@migruiz4 migruiz4 deleted the kafka-upgrade-pass branch June 13, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami kafka solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/kafka] kafka user passwords
4 participants