Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Remove registry from container list #27099

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

fmulero
Copy link
Collaborator

@fmulero fmulero commented Jun 11, 2024

Description of the change

Remove registry information (doker.io) from containers list.
Iterate recursively over all Chart.yaml file in dependencies.

Benefits

Keep same format as previous files.
Ensure we don't miss any image in the container list.

Possible drawbacks

None

Checklist

  • [NA] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • [NA] Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • [NA] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Jun 11, 2024
@github-actions github-actions bot requested a review from rafariossaa June 11, 2024 14:52
@fmulero fmulero changed the title [CI/CD] Remove registry in promotion files [CI/CD] Remove registry from container list Jun 11, 2024
andresbono
andresbono previously approved these changes Jun 11, 2024
@fmulero fmulero force-pushed the feature/upload-promotion-files-2 branch from 3b893b0 to a70d5d0 Compare June 11, 2024 15:17
Signed-off-by: Fran Mulero <[email protected]>
andresbono
andresbono previously approved these changes Jun 11, 2024
@fmulero fmulero merged commit 79a81b1 into bitnami:main Jun 11, 2024
8 checks passed
@fmulero fmulero deleted the feature/upload-promotion-files-2 branch June 11, 2024 16:28
longnbao pushed a commit to longnbao/bitnami-helm-charts that referenced this pull request Jun 12, 2024
* [CI/CD] Remove registry in promotion files

Signed-off-by: Fran Mulero <[email protected]>

* Check if dependency files exists and are not empty

Signed-off-by: Fran Mulero <[email protected]>

* Simplify condition

Signed-off-by: Fran Mulero <[email protected]>

* Analyse all 'Chart.yaml' files in dependencies

Signed-off-by: Fran Mulero <[email protected]>

---------

Signed-off-by: Fran Mulero <[email protected]>
Signed-off-by: Long Bao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants