Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/influxdb] Feature to restore from AWS S3 #30696

Closed
wants to merge 16 commits into from

Conversation

shreekumar2901
Copy link
Contributor

Description of the change

This contribution includes a feature to restore data from AWS S3 endpoint. Whenever influxdb deployment comes up, an initContainer will be spinned up and it will fetch the data from the backup stored in AWS s3. The restored data will be stored in a separate PVC.

Benefits

Automatic restore of backed up data from AWS S3

Possible drawbacks

  • When no providers are provided(i.e data is stored in PVC itself) ideally restore should happen from backups directory itself. The proposed change does not include this scenario.
  • Proposed change is tested only with AWS S3 endpoint

Applicable issues

When backup and restore is enabled with only PVC(i.e no external providers such as AWS), restore won't work. So, in this scenario, it's not recommended with the proposed change to enable restore.

Additional information

The restore PVC is mounted to the influxdb deployment. Restore scripts can be included in custom-init-scripts

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the PR! Please let us know when it is ready for review.

@shreekumar2901 shreekumar2901 force-pushed the feature/restore-from-aws-s3 branch from eef8dc6 to f195131 Compare December 4, 2024 07:02
@andilar
Copy link

andilar commented Dec 5, 2024

OSPO check successful @shreekumar2901. 🥇

shreekumar2901 and others added 14 commits December 11, 2024 07:38
Signed-off-by: Shreekumar Hegde <[email protected]>
Signed-off-by: Shreekumar Hegde <[email protected]>
Signed-off-by: Shreekumar Hegde <[email protected]>
Signed-off-by: Shreekumar Hegde <[email protected]>
Signed-off-by: Shreekumar Hegde <[email protected]>
Signed-off-by: Shreekumar Hegde <[email protected]>
Signed-off-by: Shreekumar Hegde <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@shreekumar2901 shreekumar2901 force-pushed the feature/restore-from-aws-s3 branch from 59a97c8 to cb64216 Compare December 11, 2024 06:41
Signed-off-by: Shreekumar Hegde <[email protected]>
@shreekumar2901 shreekumar2901 marked this pull request as ready for review December 11, 2024 06:43
Signed-off-by: Bitnami Containers <[email protected]>
@shreekumar2901
Copy link
Contributor Author

@javsalgar Ready for Review

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 11, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 11, 2024
@github-actions github-actions bot removed the request for review from javsalgar December 11, 2024 09:45
@github-actions github-actions bot requested a review from jotamartos December 11, 2024 09:45
@jotamartos
Copy link
Contributor

Hi @shreekumar2901,

Thank you for your contribution. This is a very specific use-case, highly attached to AWS, and the changes you are applying can be easily deployed using influxdb.initContainers, influxdb.extraVolumeMounts, influxdb.extraVolumes and extraDeploy parameters.

I'm going to close this PR now but I'd like to thank you for taking the time to propose this change. We will revisit this feature in the future if more users request it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
influxdb solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants