[bitnami/clickhouse] Fix: bind ipv6 and ipv4 by default #31200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify `defaultConfigurationOverrides` to listen on ipv4 and ipv6 and replace the default launch args of the `setup.sh` to accept args Signed-off-by: Jules Lefebvre <[email protected]>
4 tasks
Increase clickhouse version number from 7.1.4 to 7.1.5 Signed-off-by: Jules Lefebvre <[email protected]>
JulesdeCube
force-pushed
the
clickhouse-ipv6-support
branch
from
34d62e9 to
af80ed4
Compare
|
hello still failing with the |
|
I just accepted the invitation on behalf of @bitnami-bot and the job is running again. If everything is ok, a new commit should be added authored by the bot |
|
It seems there is still something wrong with the permission: |
JulesdeCube
changed the title
JulesdeCube
force-pushed
the
clickhouse-ipv6-support
branch
from
8606f09 to
af80ed4
Compare
Signed-off-by: Bitnami Containers <[email protected]>
bitnami-bot
added
verify
|
hello I manage to fix the probleme by running the CI localy and push the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is re-open of #31168 (see #31168 (comment))
Motivation
The current clickhouse helm chart don't support ipv6 only cluster.
Context
By default clickhouse bind localhost on ipv4 and ipv6 (see https://github.com/ClickHouse/ClickHouse/blob/master/programs/server/config.xml#L253).
The bitnami container override this behaviors and bind to any ipv4 by passing
-- --listen_host=0.0.0.0toclickhouse-servervia theCMD(see https://github.com/bitnami/containers/blob/main/bitnami/clickhouse/24/debian-12/Dockerfile#L60).this is easily override to listen on ivp6 by changing the container command to
/opt/bitnami/scripts/clickhouse/run.sh -- --listen_host="::".The helm chart use an hard coded script as it's entry with no possibility to pass/override argument to
clickhouse-server. (see https://github.com/bitnami/charts/blob/main/bitnami/clickhouse/templates/scripts-configmap.yaml)Description of the change
this PR:
clickhouse-serverarguments.clickhouse-serverarguments.defaultConfigurationOverridesto listen on ipv4 and ipv6Benefits
Add Support for ipv6 only cluster
Possible drawbacks
It's harder to change
listen_hostin the xml config file.Applicable issues
related with OneUptime/oneuptime#1348
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm