Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/moodle] #31199 Fix invalid imagePullSecrets on container level #31208

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[bitnami/moodle] #31199 Fix invalid imagePullSecrets on container level #31208

wants to merge 2 commits into from

Conversation

RalfBarth
Copy link

Description of the change

Defining imagePullSecrets on container level is against spec (https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#containers). They have to be defined on pod level, which is already covered.

Benefits

Being able to deploy without error with certificates.customCAs defined.

Possible drawbacks

None as imagePullSecrets on pod level are already covered.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@RalfBarth
🐛 bitnami#31199 Remove imagePullSecrets from init-container spec.
370b981 
Defining imagePullSecrets on container level is against spec (https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#containers). They have to be defined on pod level, which is already covered.

Signed-off-by: Ralf Barth <[email protected]>
@github-actions github-actions bot added moodle triage Triage is needed labels Jan 3, 2025
@github-actions github-actions bot requested a review from javsalgar January 3, 2025 13:27
@bitnami-bot
Update CHANGELOG.md
f14882c 
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 3, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 3, 2025
@github-actions github-actions bot removed the request for review from javsalgar January 3, 2025 14:47
@github-actions github-actions bot requested a review from juan131 January 3, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan131 juan131 Awaiting requested review from juan131

At least 1 approving review is required to merge this pull request.

Assignees

@juan131 juan131

Labels
in-progress moodle verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/moodle] imagePullSecrets on container level is against spec
5 participants
@RalfBarth @javsalgar @juan131 @carrodher @bitnami-bot