-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/rabbitmq] remove undefined rts key from network policy template #31210
[bitnami/rabbitmq] remove undefined rts key from network policy template #31210
Conversation
Signed-off-by: justin hallquist <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Is there a way to see the failed spec for the VIB Verify test? Aside from that, it seems unlikely that this change would break the test since the runtime-parameters.yaml does not specify a For some additional digging, I did run the test on two different clusters:
Would you happen to have any suggestions for next steps here on my end? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change related to the versioning
Co-authored-by: David Gomez <[email protected]> Signed-off-by: Justin Hallquist <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Description of the change
Removes a undefined
rts
key fromnetworkpolicy.yaml
Currently, modifying the
.Values.extraEgress
fails chart rendering as the template is looking for anrts
key, which is neither specified in the documentation of the.Values
nor present anywhere else in the chart for reference points as to how to use it.The error produced when
.Values.extraEgress
is defined:The work around is to define both
.Values.extraEgress
and.Values.rts.extraEgress
to pass the initial feature flag and enable the block renderBy removing the undefined
rts
key, the workaround is no longer necessary and the template matches the.Values.extraEgress
documentationBenefits
.Values.extraEgress
expected behavior reestablished.Values.extraEgress
documentation validityextraIngress
interfacePossible drawbacks
Nonbackwards compatibility for anyone who added a
.Values.rts
block to work around the issueApplicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm