Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/rabbitmq] remove undefined rts key from network policy template #31210

Conversation

JustinHallquist
Copy link
Contributor

Description of the change

Removes a undefined rts key from networkpolicy.yaml

Currently, modifying the .Values.extraEgress fails chart rendering as the template is looking for an rts key, which is neither specified in the documentation of the .Values nor present anywhere else in the chart for reference points as to how to use it.

The error produced when .Values.extraEgress is defined:

Helm upgrade failed: template: rabbitmq/templates/networkpolicy.yaml:47:64: executing "rabbitmq/templates/networkpolicy.yaml" at <.Values.rts.networkPolicy.extraEgress>: nil pointer evaluating interface {}.networkPolicy

The work around is to define both .Values.extraEgress and .Values.rts.extraEgress to pass the initial feature flag and enable the block render

By removing the undefined rts key, the workaround is no longer necessary and the template matches the .Values.extraEgress documentation

Benefits

  • .Values.extraEgress expected behavior reestablished
  • Restores .Values.extraEgress documentation validity
  • Matches the extraIngress interface

Possible drawbacks

Nonbackwards compatibility for anyone who added a .Values.rts block to work around the issue

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added rabbitmq triage Triage is needed labels Jan 3, 2025
@github-actions github-actions bot requested a review from carrodher January 3, 2025 15:52
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 3, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 3, 2025
@github-actions github-actions bot removed the request for review from carrodher January 3, 2025 19:02
@github-actions github-actions bot requested a review from dgomezleon January 3, 2025 19:02
@JustinHallquist
Copy link
Contributor Author

Is there a way to see the failed spec for the VIB Verify test?
All I can see is Error: Execution graph succeeded, however some tasks didn't pass the verification. and an execution graph url link I do not have access to view.

Aside from that, it seems unlikely that this change would break the test since the runtime-parameters.yaml does not specify a networkPolicy.extraEgress so it would have been feature flagged off with or without the update.

For some additional digging, I did run the test on two different clusters:

  • EKS cluster which passed (I did use a ClusterIP rather than a Load Balancer)
  • local k3s cluster which failed 2775 -> 2777 mnensia perms (the rest of the tests passed) so I believe that's more likely due to my storage class provisioner defaults and nothing to do with network policies

Would you happen to have any suggestions for next steps here on my end?

Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change related to the versioning

bitnami/rabbitmq/Chart.yaml Outdated Show resolved Hide resolved
JustinHallquist and others added 2 commits January 7, 2025 08:54
Co-authored-by: David Gomez <[email protected]>
Signed-off-by: Justin Hallquist <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@dgomezleon dgomezleon enabled auto-merge (squash) January 7, 2025 14:09
@dgomezleon dgomezleon merged commit 1e98bac into bitnami:main Jan 7, 2025
10 checks passed
@JustinHallquist JustinHallquist deleted the bitnami-rabbitmq_fix-networkpolicy-extra-egress branch January 7, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rabbitmq solved verify Execute verification workflow for these changes
Projects
None yet
4 participants