Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/etcd] fixed tls enable handling and v3 environment variable support for defrag cronjob #31270

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

sachinphogat
Copy link
Contributor

@sachinphogat sachinphogat commented Jan 9, 2025

Description of the change

  1. Modified Environment Variables in Defrag Cronjob to for etcdctl v3 as previously specified were only supported by etcdctl v2 and defrag cronjob was not able to use them.
  2. Added changing endpoints to have https:// instead of http:// if tls is enabled in defrag cronjob

Benefits

With the above changes defrag job is created properly and able to succeed without any issues.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added etcd triage Triage is needed labels Jan 9, 2025
@github-actions github-actions bot requested a review from carrodher January 9, 2025 06:38
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher marked this pull request as ready for review January 9, 2025 06:53
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 9, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 9, 2025
@github-actions github-actions bot removed the request for review from carrodher January 9, 2025 06:54
@github-actions github-actions bot requested a review from alvneiayu January 9, 2025 06:54
@sachinphogat
Copy link
Contributor Author

Can we review and merge this for next patch version release?

@alvneiayu
Copy link
Contributor

hi @sachinphogat

First of all, thanks a lot for your PR. Just a question about the changes, those new variables are compatible with the v2 too? just to not break the retrocompatibility.

Thanks a lot

Álvaro

@sachinphogat
Copy link
Contributor Author

As per etcd documentations, above env variables are supported for v3 only. There are different flags for v2 and v3.
But as per all the latest containers, they are using v3 only, so ideally we should have these changes merged.

alvneiayu and others added 2 commits January 20, 2025 10:30
Signed-off-by: Alvaro Neira Ayuso <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
alvneiayu
alvneiayu previously approved these changes Jan 20, 2025
@alvneiayu alvneiayu enabled auto-merge (squash) January 20, 2025 09:45
Signed-off-by: Alvaro Neira Ayuso <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@alvneiayu alvneiayu merged commit c3c3e43 into bitnami:main Jan 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
etcd solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/etcd] Defrag Job TLS Flags & Endpoint URL Issue
4 participants