Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added langfuse-langchain and langfuse int as options #2

Closed
wants to merge 1 commit into from

Conversation

EmilK15
Copy link
Collaborator

@EmilK15 EmilK15 commented Dec 20, 2024

Summary

This adds a Langfuse option for the Ollama chat model.
This cannot be added to the embeddings model because there is no Callback field in the input for the OllamaEmbeddings constructor.

image image

Looking into why embeddings doesn't have a embeddings field looks like the "ROI wasn't worth it" according to them:
langchain-ai/langchain#15258
langchain-ai/langchain#7920

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Collaborator

@roy-coder roy-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link

github-actions bot commented Jan 3, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@roy-coder roy-coder closed this Jan 3, 2025
@roy-coder roy-coder deleted the ollama-langfuse-int branch January 3, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants