-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actionlint to workflow linter #39
Conversation
Great job, no security vulnerabilities found in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! It looks good to me. A small suggestion from me would be to add a prerequisite in the README that a package manager (brew
for macOS and chocolatey
for Windows ) is needed to run the project.
🎟️ Tracking
From BRE-469
📔 Objective
Workflow Linter V2 is meant to run alongside Actionlint, so it makes sure to run Actionlint as a part of the default workflow linter run.
Enabled for Workflow-linter workflows only so far. Other repositories with settings override will need the job added to their settings.yaml file
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes