Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actionlint to workflow linter #39

Merged
merged 74 commits into from
Jan 14, 2025
Merged

Add actionlint to workflow linter #39

merged 74 commits into from
Jan 14, 2025

Conversation

AmyLGalles
Copy link
Contributor

@AmyLGalles AmyLGalles commented Dec 27, 2024

🎟️ Tracking

From BRE-469

📔 Objective

Workflow Linter V2 is meant to run alongside Actionlint, so it makes sure to run Actionlint as a part of the default workflow linter run.

Enabled for Workflow-linter workflows only so far. Other repositories with settings override will need the job added to their settings.yaml file

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@AmyLGalles AmyLGalles added the enhancement New feature or request label Dec 27, 2024
@AmyLGalles AmyLGalles requested a review from a team as a code owner December 27, 2024 16:55
@AmyLGalles AmyLGalles changed the title Agalles/bwwl actionlint Add actionlint to workflow linter Dec 27, 2024
@AmyLGalles AmyLGalles closed this Dec 27, 2024
Copy link

github-actions bot commented Dec 27, 2024

Logo
Checkmarx One – Scan Summary & Details7bcbf231-4f3e-4b33-8d48-4469f13c703d

Great job, no security vulnerabilities found in this Pull Request

@AmyLGalles AmyLGalles reopened this Dec 30, 2024
Eeebru
Eeebru previously approved these changes Dec 31, 2024
@AmyLGalles AmyLGalles removed the request for review from Eeebru January 7, 2025 01:30
@AmyLGalles AmyLGalles marked this pull request as draft January 7, 2025 01:30
@AmyLGalles AmyLGalles requested a review from mimartin12 January 13, 2025 15:12
Copy link
Contributor

@michalchecinski michalchecinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It looks good to me. A small suggestion from me would be to add a prerequisite in the README that a package manager (brew for macOS and chocolatey for Windows ) is needed to run the project.

@AmyLGalles AmyLGalles marked this pull request as ready for review January 14, 2025 15:05
@AmyLGalles AmyLGalles merged commit bcbdda5 into main Jan 14, 2025
8 checks passed
@AmyLGalles AmyLGalles deleted the agalles/bwwl-actionlint branch January 14, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request version:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants