IO stats unit test fixes #1896
Merged
IO stats unit test fixes #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Thejas-bhat
commented
Nov 3, 2023
•
Thejas-bhat
commented
- the recent index sections format uncovered some bugs in the io stats computation - specifically around the docValues area.
- furthermore, there is additional metadata being read as part of format changes - which is the fieldsSection index.
Thejas-bhat
force-pushed
the
refactor-sections
branch
from
f321aad to
002cbac
Compare
go.mod
Outdated
| ) | ||
|
|
||
| replace github.com/blevesearch/zapx/v16 => ../zapx |
There was a problem hiding this comment.
You can remove this and use the branch refactor-section for zapx/v16 before running go mod tidy again. This is until we merge refactor-section into master.
abhinavdangeti
force-pushed
the
unstable
branch
from
f1e2f1f to
0c7440f
Compare
Thejas-bhat
force-pushed
the
refactor-sections
branch
3 times, most recently
from
6c77b83 to
32bd6bc
Compare
Thejas-bhat
force-pushed
the
refactor-sections
branch
from
32bd6bc to
c634e54
Compare
Thejas-bhat
force-pushed
the
refactor-sections
branch
from
c634e54 to
8c0c405
Compare
Thejas-bhat
force-pushed
the
refactor-sections
branch
from
a2642ff to
a205bb5
Compare
Thejas-bhat
changed the title
|
abhinavdangeti
requested review from
metonymic-smokey,
CascadingRadium,
Likith101 and
moshaad7
abhinavdangeti
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.