-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KNN Operator #1908
Merged
Merged
Add KNN Operator #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonymic-smokey
force-pushed
the
knn-op
branch
from
November 13, 2023 13:37
8ee97ae
to
182daac
Compare
metonymic-smokey
force-pushed
the
knn-op
branch
from
November 17, 2023 04:35
182daac
to
00b5d9f
Compare
Thejas-bhat
reviewed
Nov 17, 2023
metonymic-smokey
force-pushed
the
knn-op
branch
from
November 17, 2023 05:57
00b5d9f
to
e7e309d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but add some unit tests please.
metonymic-smokey
force-pushed
the
knn-op
branch
from
November 21, 2023 05:57
e7e309d
to
ee4c5c2
Compare
metonymic-smokey
force-pushed
the
knn-op
branch
from
November 21, 2023 05:59
ee4c5c2
to
674b827
Compare
Yo, you've clearly not tested your unit test code -
|
abhinavdangeti
requested review from
CascadingRadium,
Likith101 and
moshaad7
November 21, 2023 17:23
metonymic-smokey
force-pushed
the
knn-op
branch
from
November 21, 2023 17:31
c55f9ce
to
dc9ec92
Compare
abhinavdangeti
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a user to specify a KNN Operator to determine if KNN hits are conjuncted/disjuncted with filter query hits.