Adding KNN scorer explanation #1914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonymic-smokey
force-pushed
the
knn_scorer
branch
2 times, most recently
from
f386d79 to
efaeacb
Compare
metonymic-smokey
requested review from
abhinavdangeti,
Thejas-bhat,
CascadingRadium,
Likith101 and
moshaad7
metonymic-smokey
changed the title
abhinavdangeti
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Looks fine to me.
@metonymic-smokey would you add a sample snippet of the "explain score" output to the commit message here.
Also, I'm glad you've set the base branch to MB-59102 so there'd be no conflicts, but I think we should merge this into unstable after the base PR has been so we don't squash this into it and create a separate commit entry for this.
metonymic-smokey
force-pushed
the
knn_scorer
branch
from
efaeacb to
3b9f58d
Compare
|
Done, pls let me know what you think. |
Includes: * dd26ea1 Thejas-bhat | command line tool support for vector search (#175) * d292ef9 Thejas-bhat | replacing the flat index with the IVF family index. (#180) * f5e149a Thejas-bhat | bug fix: accounting the vecIDs approriately while merging (#179) * 0296d71 Thejas-bhat | optimization: avoiding storing of bitmaps when vector is in a single document (#181) * 6b9b047 Abhi Dangeti | MB-59692: Respect choice of similarity metric, [email protected] (#182) * e1fe4fb Abhi Dangeti | MB-59569: Upgrade to blevesearch/[email protected] (#183)
# Jira [MB-59102](https://issues.couchbase.com/browse/MB-59102) ## Description When performing a MultiSearch across an alias representing a partitioned index, we need special logic to merge the KNN results together into the final search result. --------- Co-authored-by: Abhinav Dangeti <[email protected]>
An error occurred while trying to automatically change base from
MB-59102
to
unstable
November 21, 2023 17:11
An error occurred while trying to automatically change base from
MB-59102
to
unstable
November 21, 2023 17:11
An error occurred while trying to automatically change base from
MB-59102
to
unstable
November 21, 2023 17:11
abhinavdangeti
requested changes
Nov 21, 2023
This PR allows a user to specify a KNN Operator to determine if KNN hits are conjuncted/disjuncted with filter query hits.
Sample explanation:
{
"value": 0.125,
"message": "weight(desc:query Vector^1.000000 in one), product of:",
"children": [
{
"value": 0.5,
"message": "queryWeight(desc:query Vector^1.000000), product of:",
"children": [
{
"value": 1,
"message": "boost"
},
{
"value": 0.5,
"message": "queryNorm"
}
]
},
{
"value": 0.25,
"message": "fieldWeight(desc in doc one), score of:",
"children": [
{
"value": 0.25,
"message": "vector(field(desc:one) with similarity_metric(dot_product)=0.250000"
}
]
}
]
}
metonymic-smokey
force-pushed
the
knn_scorer
branch
from
3b9f58d to
6475b83
Compare
|
Pls review this PR instead - #1899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a score Explanation to the KNN scorer, along with a unit test.
Also, contains a minor refactor of scoring related code.