Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MB-62230 - Pre-filtering Optimisation #2098

Merged
merged 8 commits into from
Nov 13, 2024
Merged

MB-62230 - Pre-filtering Optimisation #2098

merged 8 commits into from
Nov 13, 2024

Conversation

metonymic-smokey
Copy link
Member

@metonymic-smokey metonymic-smokey commented Nov 11, 2024

This PR -

  1. Avoids creating document matches for the pre-filter phase, when IDs suffice.
  2. Re-uses document matches by adding them to the doc match pool after each hit.

Verified

This commit was signed with the committer’s verified signature.
search/collector/eligible.go Outdated Show resolved Hide resolved
search/collector/eligible.go Outdated Show resolved Hide resolved
@abhinavdangeti abhinavdangeti added this to the v2.4.3 milestone Nov 11, 2024
Copy link
Member

@abhinavdangeti abhinavdangeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments (all around naming and readability) that override some earlier ones.

search/collector/eligible.go Outdated Show resolved Hide resolved
search/collector/eligible.go Outdated Show resolved Hide resolved
search/collector/eligible.go Outdated Show resolved Hide resolved
search/collector/eligible.go Outdated Show resolved Hide resolved
search/collector/eligible.go Outdated Show resolved Hide resolved
@abhinavdangeti abhinavdangeti merged commit e72f7c2 into master Nov 13, 2024
9 checks passed
@abhinavdangeti abhinavdangeti deleted the sample2 branch November 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants