-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interfaces for thesaurus datatype #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CascadingRadium
commented
Oct 14, 2024
•
edited
Loading
edited
- Add interfaces that will abstract the underlying roaring64 bitmaps and its iterators used by the thesaurus for storing synonyms.
CascadingRadium
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
Likith101 and
moshaad7
October 14, 2024 13:54
CascadingRadium
changed the title
interfaces for thesaurus datatype
Interfaces for thesaurus datatype
Dec 9, 2024
abhinavdangeti
previously approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok, let's wait to bump up bleve_index_api version though.
ok i have added a few commentary here |
abhinavdangeti
approved these changes
Dec 11, 2024
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
Dec 19, 2024
- Allow setting up `synonym_sources` in the index mapping, which will follow its own ingest pipeline, ingesting special synonym definitions using the IndexSynonym API(). - A `synonym_source` can be set like an analyzer to a field mapping and can be set as a default option at the document mapping or the index mapping level. - Each `synonym_source` can have its own analyzer, making it flexible to allow for compatibility with the language analyzer specified for its corresponding mapping. - Compatibility with every term-based query where the term gets expanded to include its synonyms at query time. - Dependencies: - blevesearch/[email protected] - blevesearch/bleve_index_api#57 - blevesearch/[email protected] - blevesearch/scorch_segment_api#46 - blevesearch/[email protected] - blevesearch/vellum#22 - blevesearch/zapx@v16@latest - blevesearch/zapx#268 --------- Co-authored-by: Abhinav Dangeti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.