-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Thesaurus API and Synonym Index Handling in Search #268
Conversation
e19bcb6
to
91ff49a
Compare
d3e2c9a
to
75144dd
Compare
6dfc0ab
to
a6ea1b0
Compare
5d87f9f
to
8bbd323
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly ok to me. One comment around naming/commentary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CascadingRadium . Let's get this in for now and incrementally improve the area as and when needed.
- Allow setting up `synonym_sources` in the index mapping, which will follow its own ingest pipeline, ingesting special synonym definitions using the IndexSynonym API(). - A `synonym_source` can be set like an analyzer to a field mapping and can be set as a default option at the document mapping or the index mapping level. - Each `synonym_source` can have its own analyzer, making it flexible to allow for compatibility with the language analyzer specified for its corresponding mapping. - Compatibility with every term-based query where the term gets expanded to include its synonyms at query time. - Dependencies: - blevesearch/[email protected] - blevesearch/bleve_index_api#57 - blevesearch/[email protected] - blevesearch/scorch_segment_api#46 - blevesearch/[email protected] - blevesearch/vellum#22 - blevesearch/zapx@v16@latest - blevesearch/zapx#268 --------- Co-authored-by: Abhinav Dangeti <[email protected]>
Thanks for merging @abhinavdangeti |
for creating the thesaurus in the search index.
segments (separating it from the inverted and vector indexes), and manage the synonym index
merging during segment merges.