Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling a case to avoid bringing faiss index to memory unnecessarily #279

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

Thejas-bhat
Copy link
Member

  • In update/delete heavy scenario where we short circuit the merge path, we end up reading a faiss index to the memory unnecessarily and it can potentially stay in memory till the reconstruction of all valid vectors is complete (which is not ideal).
  • Also refactoring the vecIndexes []*faiss.IndexImpl construct to indexes []*vecIndexInfo just so we don't have to read info from two different slices while reconstructing vectors.

@Thejas-bhat Thejas-bhat changed the title Handling an edge to avoid bringing index to memory unnecessarily Handling a case to avoid bringing faiss index to memory unnecessarily Oct 28, 2024
@abhinavdangeti abhinavdangeti merged commit d29eb55 into master Oct 30, 2024
6 checks passed
@abhinavdangeti abhinavdangeti deleted the refactor branch October 30, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants