MB-64360 - Guardrail fix for missing vectors #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonymic-smokey
requested review from
abhinavdangeti,
Thejas-bhat,
CascadingRadium and
Likith101
metonymic-smokey
changed the base branch from
master
to
v16-trinity-couchbase
metonymic-smokey
force-pushed
the
guardrail
branch
from
8dcbb18 to
b176f02
Compare
Thejas-bhat
reviewed
Nov 28, 2024
CascadingRadium
approved these changes
Nov 28, 2024
Thejas-bhat
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a doc has invalid vector fields but valid non-vector fields, filter hit IDs may be ineligible for the kNN since the document does not have any/valid vectors. This PR adds a check to avoid kNN in such cases.