Skip to content

Commit

Permalink
fix: Only add metadata URIs if we have tokenIDs.
Browse files Browse the repository at this point in the history
  • Loading branch information
tyler-smith committed Oct 30, 2023
1 parent 8c97d37 commit c1d54c9
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions eth/tracers/blocknative/decoder/asset.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,11 @@ func decodeERC721Metadata(evmCall evmCallFn, addr common.Address, tokenID *big.I
if metadata.Symbol, err = decodeMetadataSymbol(evmCall, addr); err != nil {
log.Trace("failed to decode ERC721 symbol", "err", err)
}
if metadata.URI, err = decodeMetadataTokenURI(evmCall, addr, tokenID); err != nil {
log.Trace("failed to decode ERC721 tokenURI", "err", err)

if tokenID != nil {
if metadata.URI, err = decodeMetadataTokenURI(evmCall, addr, tokenID); err != nil {
log.Trace("failed to decode ERC721 tokenURI", "err", err)
}
}

return metadata
Expand All @@ -82,8 +85,10 @@ func decodeERC1155Metadata(evmCall evmCallFn, addr common.Address, tokenID *big.
var err error
metadata := AssetMetadata{Type: AssetTypeERC1155}

if metadata.URI, err = decodeMetadataURI(evmCall, addr, tokenID); err != nil {
log.Trace("failed to decode ERC1155 URI", "err", err)
if tokenID != nil {
if metadata.URI, err = decodeMetadataURI(evmCall, addr, tokenID); err != nil {
log.Trace("failed to decode ERC1155 URI", "err", err)
}
}

return metadata
Expand Down

0 comments on commit c1d54c9

Please sign in to comment.