Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use lower() when comparing lower chars #3115

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

dougsland
Copy link
Contributor

Just checking some code, better use good practices.

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2025

CLA assistant check
All committers have signed the CLA.

@dougsland dougsland force-pushed the lower branch 2 times, most recently from 787afb7 to 3c3c039 Compare January 30, 2025 16:47
Just checking some code, better use good practices.

Signed-off-by: Douglas Schilling Landgraf <[email protected]>
@dougsland
Copy link
Contributor Author

@patrickelectric is there a ./build-locally to test such changes locally? Still learning the process to contribute.

@patrickelectric
Copy link
Member

@patrickelectric is there a ./build-locally to test such changes locally? Still learning the process to contribute.

We usually run the docker build command or let CI build for us, if you configure the docker CI username and password secrets.

We have a small wiki for development here: https://github.com/bluerobotics/BlueOS/wiki/Development

@patrickelectric patrickelectric merged commit 245e0e4 into bluerobotics:master Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants