Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running tests in environment with NO_COLOR=1 #130

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Nov 24, 2023

Fix running the test suite when pytest is run with NO_COLOR=1 set in the environment. An fixture is autoused to ensure that the variables are removed for the scope of the test, while they are respected e.g. by pytest itself.

@mgorny
Copy link
Contributor Author

mgorny commented Nov 24, 2023

The failures don't seem related to my changes.

Fix running the test suite when pytest is run with NO_COLOR=1 set
in the environment.  An fixture is autoused to ensure that the variables
are removed for the scope of the test, while they are respected
e.g. by pytest itself.
@borntyping borntyping merged commit 6a14458 into borntyping:main Dec 2, 2023
3 of 12 checks passed
@mgorny mgorny deleted the nocolor branch December 2, 2023 16:39
@mgorny
Copy link
Contributor Author

mgorny commented Dec 2, 2023

Thank you!

@borntyping
Copy link
Owner

Thanks for your contribution! Released as part of 6.8.0.

DonRobo referenced this pull request in DonRobo/ha-ha-integration Jul 26, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [colorlog](https://togithub.com/borntyping/python-colorlog) |
`==6.7.0` -> `==6.8.2` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/colorlog/6.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/colorlog/6.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/colorlog/6.7.0/6.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/colorlog/6.7.0/6.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>borntyping/python-colorlog (colorlog)</summary>

###
[`v6.8.2`](https://togithub.com/borntyping/python-colorlog/releases/tag/v6.8.2):
6.8.2

[Compare
Source](https://togithub.com/borntyping/python-colorlog/compare/v6.8.0...v6.8.2)

#### What's Changed

- Update package links in README by
[@&#8203;buhtz](https://togithub.com/buhtz) in
[https://github.com/borntyping/python-colorlog/pull/131](https://togithub.com/borntyping/python-colorlog/pull/131)
- Added
[docs/CONTRIBUTING.md](https://togithub.com/borntyping/python-colorlog/blob/main/docs/CONTRIBUTING.md).
-   Documented "bright" colours in the README.

#### New Contributors

- [@&#8203;buhtz](https://togithub.com/buhtz) made their first
contribution in
[https://github.com/borntyping/python-colorlog/pull/131](https://togithub.com/borntyping/python-colorlog/pull/131)

**Full Changelog**:
borntyping/python-colorlog@v6.8.0...v6.8.2

###
[`v6.8.0`](https://togithub.com/borntyping/python-colorlog/releases/tag/v6.8.0):
6.8.0

[Compare
Source](https://togithub.com/borntyping/python-colorlog/compare/v6.7.0...v6.8.0)

#### What's Changed

- Remove universal wheel, python 2 is unsupported by
[@&#8203;gopackgo90](https://togithub.com/gopackgo90) in
[https://github.com/borntyping/python-colorlog/pull/126](https://togithub.com/borntyping/python-colorlog/pull/126)
- Fix running tests in environment with NO_COLOR=1 by
[@&#8203;mgorny](https://togithub.com/mgorny) in
[https://github.com/borntyping/python-colorlog/pull/130](https://togithub.com/borntyping/python-colorlog/pull/130)

#### New Contributors

- [@&#8203;gopackgo90](https://togithub.com/gopackgo90) made their first
contribution in
[https://github.com/borntyping/python-colorlog/pull/126](https://togithub.com/borntyping/python-colorlog/pull/126)
- [@&#8203;mgorny](https://togithub.com/mgorny) made their first
contribution in
[https://github.com/borntyping/python-colorlog/pull/130](https://togithub.com/borntyping/python-colorlog/pull/130)

**Full Changelog**:
borntyping/python-colorlog@v6.7.0...v6.8.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/DonRobo/ha-ha-integration).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants