-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dependencies to be installed in 32 bits bottle #3058
Conversation
Pylint result on modfied files:
|
@orowith2os Any chance to get this PR merged? Seems the previous one was approved: #2861 (comment) |
@koplo199 needs testing, otherwise I can look at merging it. |
SonarQube Quality Gate |
if self.manager.utils_conn.status == False: | ||
self.stack.set_visible_child_name("page_offline") | ||
if not self.manager.utils_conn.status: | ||
self.stack.set_visible_child_name("page_offline") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.stack.set_visible_child_name("page_offline") | |
self.stack.set_visible_child_name("page_offline") |
Remove space at end of line
Seems the part handling the Bottles/bottles/backend/managers/dependency.py Lines 130 to 133 in 208b8b7
(Apparently GitHub does not allow suggesting change to unmodified files/lines, so I cannot leave a suggestion there) |
It also seems the Bottles/bottles/frontend/widgets/dependency.py Lines 152 to 157 in 6133d89
I also can't leave a change suggestion, for the same reason. |
@Kinsteen Sorry to ping you directly, I assume you've been busy in life lately. Hope you don't mind if I implement the requested changes above so we could merge soon. I'll do so by forking your branch 32bits-dependencies, meaning you'll of course retain full authorship of the commits present in there. |
@koplo199 I have dropped working on Bottles, I would gladly appreciate if you could do the modifications :) |
Closing in favor of #3101 |
Description
See #2861, couldn't update because I don't have write permissions anymore.
I didn't test, but you can look at the previous PR to know what it does and how to test it.
Also, an update to the .pot files should be required to have the new string properly translated.