Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download progress on main loop/thread. #3607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vingian
Copy link
Contributor

@Vingian Vingian commented Dec 16, 2024

Description

Schedule the download progress update on the main loop/thread.

Fix #3578, fix #3553 and fix #3629

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Update download progress through the main thread.
Copy link
Contributor

Pylint result on modfied files:
************* Module bottles.frontend.widgets.component
bottles/frontend/widgets/component.py:97:45: W0511: TODO: unimplemented (fixme)
bottles/frontend/widgets/component.py:21:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/widgets/component.py:90:35: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/widgets/component.py:88:23: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/component.py:110:27: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/widgets/component.py:108:24: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/component.py:126:25: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/component.py:134:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/frontend/widgets/component.py:182:0: R0903: Too few public methods (0/2) (too-few-public-methods)

@EmoonX
Copy link
Contributor

EmoonX commented Dec 18, 2024

Minor and meta thingie, but I think GitHub missed the second issue here:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants