Web changes for NWB conversion #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deirdre-k
reviewed
Nov 21, 2024
| @@ -40,6 +40,11 @@ <h3 class="benefits_heading is-size-3-mobile">Welcome, {{ user.email }}</h3> | |||
| </p> | |||
| </div> | |||
| {% endfor %} | |||
| <div class="box"> | |||
| <p class="benefits_info is-size-5-mobile"> | |||
| Convert NWB data to a BrainScore data plugin <a href="https://{{ request.get_host }}/profile/nwb">here</a>. | |||
There was a problem hiding this comment.
Should this be a domain-specific button/address? For example, submission is at http://{{ request.get_host }}/profile/{{ domain }}/submit
There was a problem hiding this comment.
Leave as is for now, look for a place to add a disclaimer that this is only for vision
| <br> | ||
|
|
||
| <p>Download a template JSON file below and fill in the required values.</p> | ||
| <a href="{% static "benchmarks/example_json.json" %}" class="button button-primary" download> |
| @@ -43,6 +43,7 @@ | |||
| path('profile/submit/', user.Upload.as_view(domain="vision"), name=f'vision-submit'), | |||
| path('profile/resubmit/', partial(user.resubmit, domain="vision"), name='vision-resubmit'), | |||
| path('profile/logout/', user.Logout.as_view(domain="vision"), name='vision-logout'), | |||
| path('profile/nwb/', user.ConvertNWB.as_view(domain="vision"), name=f'convert-nwb'), | |||
There was a problem hiding this comment.
@mike-ferguson to double check domain-specific url approach
There was a problem hiding this comment.
@mike-ferguson just checking if the endpoint is good as is or if it should be profile/vision/nwb/?
static/benchmarks/example_json.json
Outdated
| { | ||
| "dandiset_id": "000788", | ||
| "nwb_file_path": "sub-pico/sub-pico_ecephys.nwb", | ||
| "exp_path": "/home/ubuntu/vision/brainscore_vision/nwb_integration/", |
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "dandiset_id": "000788", | |||
| "nwb_file_path": "sub-pico/sub-pico_ecephys.nwb", | |||
There was a problem hiding this comment.
Note to change values to descriptors
mike-ferguson
requested changes
Nov 22, 2024
Co-authored-by: deirdre-k <[email protected]>
Co-authored-by: Michael Ferguson <[email protected]>
Co-authored-by: Michael Ferguson <[email protected]>
Co-authored-by: Michael Ferguson <[email protected]>
Co-authored-by: Michael Ferguson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.