Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

When Download is canceled by the chromium engine close the save dialog. #10775

Closed

Conversation

gnanasekar-somanathan
Copy link

When Download is canceled by the chromium engine close the save dialog.

@codecov-io
Copy link

codecov-io commented Sep 2, 2017

Codecov Report

Merging #10775 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10775      +/-   ##
==========================================
- Coverage   54.16%   54.15%   -0.02%     
==========================================
  Files         247      247              
  Lines       21543    21549       +6     
  Branches     3334     3335       +1     
==========================================
  Hits        11669    11669              
- Misses       9874     9880       +6
Flag Coverage Δ
#unittest 54.15% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
app/filtering.js 18.39% <0%> (-0.19%) ⬇️

@diracdeltas diracdeltas self-requested a review September 2, 2017 19:43
@diracdeltas
Copy link
Member

notes: this is to address #10644 as part of brave/muon#289

@diracdeltas
Copy link
Member

will merge after brave/muon#289 lands

@luixxiul luixxiul added this to the Backlog milestone Oct 26, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Completed work Feb 28, 2018
@bsclifton
Copy link
Member

Closing as stale; original Muon PR hasn't been accepted and there hasn't been any activity recently

@bsclifton bsclifton closed this May 30, 2018
@bsclifton bsclifton removed this from the Completed work milestone May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants