do not allow any loading of brave:// urls from anywhere

auditors @darkdh @diracdeltas
brave · Aug 3, 2018 · dddf8d5 · dddf8d5 · diracdeltas · Aug 3, 2018
1 parent ef4292b
commit dddf8d5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/brave/browser/brave_content_browser_client.cc b/brave/browser/brave_content_browser_client.cc
@@ -860,9 +860,18 @@ void BraveContentBrowserClient::GetAdditionalWebUISchemes(
   additional_schemes->push_back(content::kChromeDevToolsScheme);
 }
 
+bool BraveContentBrowserClient::CanCommitURL(
+      content::RenderProcessHost* process_host, const GURL& url) {
+  if (url.SchemeIs("brave"))
+    return false;
+  return true;
+}
+
 bool BraveContentBrowserClient::ShouldAllowOpenURL(
     content::SiteInstance* site_instance, const GURL& url) {
   GURL from_url = site_instance->GetSiteURL();
+  if (url.SchemeIs("brave"))
+    return false;
 #if BUILDFLAG(ENABLE_EXTENSIONS)
   bool result;
   if (AtomBrowserClientExtensionsPart::ShouldAllowOpenURL(

diff --git a/brave/browser/brave_content_browser_client.h b/brave/browser/brave_content_browser_client.h
@@ -119,6 +119,8 @@ class BraveContentBrowserClient : public atom::AtomBrowserClient {
       std::vector<std::string>* additional_allowed_schemes) override;
   void GetAdditionalWebUISchemes(
       std::vector<std::string>* additional_schemes) override;
+  bool CanCommitURL(
+      content::RenderProcessHost* process_host, const GURL& url) override;
   bool ShouldAllowOpenURL(content::SiteInstance* site_instance,
                                       const GURL& url) override;
   bool IsURLAcceptableForWebUI(content::BrowserContext* browser_context,