Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuubar as formatting option #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomasdundacek
Copy link
Contributor

Hi @briandunn

Thanks for this brilliant gem! After reading the discussion in #87, I've been working on an option to allow other formatters to be used with this gem.

I have re-added the -f CLI option, and eventually I would like to - in a different PR - create an option to have a .flatware file to store these options in the repo.

Closes #87

@tomasdundacek tomasdundacek force-pushed the feature/fuubar branch 3 times, most recently from 7bffdaa to dd9ca4a Compare October 21, 2024 07:55
@tomasdundacek tomasdundacek force-pushed the feature/fuubar branch 2 times, most recently from 52ee96d to 50f666b Compare October 31, 2024 07:16
@briandunn
Copy link
Owner

I am interested in merging the addition of more notification types, and the formatter const lookup. Could the actual fubar adapter be a separate gem though, like flatware-rspec-fubar or something, and adding that to your project Gemfile would enable it's use? That would be more like the patterns of rspec, and would open the door to further cool formatters without adding more maintenance to this repo.

@tomasdundacek
Copy link
Contributor Author

@briandunn Thanks for the feedback, and yes - splitting the gem makes sense. I'm a little busy currently, but I will have a look at it in near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using other rspec formatters
2 participants