Add support for ruby 3.3 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review, I can remove or modify anything you don't like, no problem. |
|
Hey @a666! thanks so much for all this work. Going through it now and everything looks awesome so far. |
This was referenced Feb 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CI tests for missing rspecs (11, 12, 13).
Adds CI tests for ruby 3.3 .
Allows the use of latest versions for dev dependencies (except aruba (that depends on cucumber) because it requires testing code changes).
Removes the bundler lock files from the appraisals because using a modern bundler (that sets "bundled by") kills CI on old ruby versions (anything older than ruby 3.0).
Adds
raccdependency so tests work on ruby3.3 as specified in #74 (comment) .Rubocop config was updated, running
rubocop -AwithNewCops: enableon codebase only seems to modify spec files. Only 2 exceptions:Gemspec/RequiredRubyVersionfeels bugged (unless I'm stupid) andGemspec/RequireMFAshould be enabled (by removing the whole section) if maintainer desires.Closes #75.