Fix: flatware hangs if a worker dies #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandunn
force-pushed
the
example/catch-cld
branch
from
a0e9640 to
dab34e2
Compare
obrie
reviewed
May 15, 2024
|
|
||
| Cleaning up. Please wait... | ||
| MESSAGE | ||
| end |
There was a problem hiding this comment.
I'm not sure this is doing what we expect it to do. CLD is an expected signal that happens when a worker gracefully shuts down as well (i.e. when it completes its job). With this current code, I get this output while specs are running:
....................................................................................................................................................................................................................................................
A worker died!
Cleaning up. Please wait...
...........................................
...which I think ends up looking like there's a problem even though there isn't. I think we'd need to differentiate between a worker process terminating with an incomplete job vs. a worker process terminating with a complete job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a fix for the problem described here.