Fix: don't assume SIGCLD is bad. Check child statuses. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandunn
force-pushed
the
fix/cld-aint-all-bad
branch
from
57e14fb to
f9823dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #84 by checking the status of the children on
CLD. If it was a clean exit ignore the signal.putsNote that there are some things about this solution that aren't ideal. I would prefer if only
Sinkbore the responsibility of things likeProcess.waitallandabort. But trying to resolve those issues introduced too many changes in light of the main release having a problem right now. So, soon hopefully.