Ed25519: Accept standard (correct) form of PKCS#8 v2 encoding #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I verified the key value is the same in the draft and the final RFC.
…for correct encoding. These new tests have the wrong expected results because of the bug that will be fixed in the next commit.
…t tagging public key. See the added API documentation for more details. Also update the test private key to the standard format.
briansmith
force-pushed
the
b/accept-rfc-pkcs8-2
branch
from
a647032 to
b9124b6
Compare
Codecov Report
@@ Coverage Diff @@
## main #1480 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 130 130
Lines 18367 18381 +14
Branches 195 195
=======================================
+ Hits 16873 16886 +13
- Misses 1460 1461 +1
Partials 34 34
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details. With this change, both the old (wrong) form and the new (correct) form are accepted.