getauxval isn't defined on uclibc, so disable dynamic feature detection #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
reviewed
Nov 13, 2023
skrap
force-pushed
the
uclibc-static-cpu-features
branch
from
5814da6 to
ad60343
Compare
briansmith
previously approved these changes
Nov 13, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
=======================================
Coverage 96.00% 96.01%
=======================================
Files 137 137
Lines 20742 20718 -24
Branches 226 226
=======================================
- Hits 19914 19893 -21
+ Misses 792 790 -2
+ Partials 36 35 -1 ☔ View full report in Codecov by Sentry. |
skrap
force-pushed
the
uclibc-static-cpu-features
branch
from
ad60343 to
64c2bd1
Compare
|
Drat I forgot to run rustfmt after adding the comment. Fixed. Sorry! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at the suggested alternative approach @briansmith suggested in #1800