ec/suite_b: Thread CPU features through functions using Modulus.
#2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the same pattern that is used in arithmetic/bigint.rs: Since we have to construct a `Modulus` at roughly the same place we have to get the proof we've done CPU feature detection, just have `Modulus` contain the `cpu::Features`, so that any function that takes a `Modulus` no longer needs a `cpu::Features` argument. Then, make a step towards threading `cpu::Features` all the way down to to the callers of the lowest-level C/assembly functions. This will facilitate a future refactoring where all dispatching based on CPU features is moved out of the assembly code, from upstream.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2181 +/- ##
=======================================
Coverage 96.93% 96.94%
=======================================
Files 154 154
Lines 20195 20238 +43
Branches 464 464
=======================================
+ Hits 19577 19619 +42
Misses 512 512
- Partials 106 107 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the same pattern that is used in arithmetic/bigint.rs: Since we have to construct a
Modulusat roughly the same place we have to get the proof we've done CPU feature detection, just haveModuluscontain thecpu::Features, so that any function that takes aModulusno longer needs acpu::Featuresargument.Then, make a step towards threading
cpu::Featuresall the way down to to the callers of the lowest-level C/assembly functions. This will facilitate a future refactoring where all dispatching based on CPU features is moved out of the assembly code, from upstream.