Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec/suite_b: Minimize scope of CommonOps members. #2182

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

briansmith
Copy link
Owner

Callers outside of ops use Modulus members instead of using CommonOps directly.

Callers outside of `ops` use `Modulus` members instead of using
`CommonOps` directly.
@briansmith briansmith self-assigned this Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.94%. Comparing base (aca068c) to head (3d5fc17).

Files with missing lines Patch % Lines
src/ec/suite_b/ecdsa/signing.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2182   +/-   ##
=======================================
  Coverage   96.93%   96.94%           
=======================================
  Files         154      154           
  Lines       20238    20238           
  Branches      464      464           
=======================================
+ Hits        19618    19619    +1     
  Misses        512      512           
+ Partials      108      107    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith merged commit 01742ba into main Dec 11, 2024
157 of 158 checks passed
@briansmith briansmith deleted the b/ec-modulus-naming branch December 11, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant